Messages in this thread | | | Date | Sun, 9 Jun 2013 10:03:47 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH 1/1] tps65090-charger: Fix AC detect |
| |
On Fri, Jun 07, 2013 at 12:07:39PM -0400, Rhyland Klein wrote: > On 6/6/2013 5:12 PM, Andrew Chew wrote: > > The VACG interrupt was not being enabled. Thus, interrupts were never > > generated when AC status changes. In addition, interrupts were never > > cleared after taking and processing the interrupt. > > > > Added the register offset for the INTR_MASK register, since this is needed > > to unmask the VACG interrupt. > > > > Enabled the VACG interrupt in tps65090_config_charger(). > > > > Cleared interrupts after processing, in tps65090_charger_isr(). > > > > Also removed unused variable "enable" in tps65090_enable_charging(), > > and fixed a typo in one of the dev_err() prints. > > > > Signed-off-by: Andrew Chew <achew@nvidia.com> > > --- > > Great! Tested and it works great on my Dalmore. > > Tested-by: Rhyland Klein <rklein@nvidia.com> > Acked-by: Rhyland Klein <rklein@nvidia.com>
Applied, thanks!
Anton
| |