Messages in this thread | | | Date | Sat, 8 Jun 2013 23:04:18 +0900 | Subject | Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer() | From | Akinobu Mita <> |
| |
2013/6/6 Imre Deak <imre.deak@intel.com>: > Looks ok to me, perhaps adding the seek functionality to the mapping > iterator would make things more generic and the mapping iterator more > resemble the page iterator. So we'd have a new sg_miter_start_offset and > call it here something like: > > sg_miter_start_offset(&miter, sgl, nents, sg_flags, skip);
I also thought something like this could be a new interface for sg_miter_* API, but I haven't found any places where it can be used yet. That's why I made it a local function and didn't create new interface.
But putting good function comment like other sg_miter_* API for new local function is harmless and it helps someone who wants interface like this in the future. So I'll do so in next version.
| |