Messages in this thread | | | Date | Sat, 08 Jun 2013 16:37:30 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] arch: asm-geniric: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' |
| |
On 06/08/2013 04:31 PM, Geert Uytterhoeven wrote: > Haven't done a real review, but my eye fell on it: >
Thank you for your review, firstly.
> On Sat, Jun 8, 2013 at 9:50 AM, Chen Gang <gang.chen@asianux.com> wrote: >> > diff --git a/arch/m32r/include/asm/atomic.h b/arch/m32r/include/asm/atomic.h >> > index 0d81697..233c743 100644 >> > --- a/arch/m32r/include/asm/atomic.h >> > +++ b/arch/m32r/include/asm/atomic.h >> > @@ -264,7 +264,7 @@ static __inline__ int __atomic_add_unless(atomic_t *v, int a, int u) >> > } >> > >> > >> > -static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) >> > +static __inline__ void atomic_clear_mask(unsigned int mask, atomic_t *addr) >> > { >> > unsigned long flags; >> > unsigned long tmp; > Shouldn't this become "unsigned int tmp" for consistency, too? >
It seems better. (although I guess: for 'm32r', both 'long' and 'int' are 32-bit).
I will wait for 1 day at least, if no additional suggestions or completions, I will send patch v2.
>> > @@ -286,7 +286,7 @@ static __inline__ void atomic_clear_mask(unsigned long mask, atomic_t *addr) >> > local_irq_restore(flags); >> > } >> > >> > -static __inline__ void atomic_set_mask(unsigned long mask, atomic_t *addr) >> > +static __inline__ void atomic_set_mask(unsigned int mask, atomic_t *addr) >> > { >> > unsigned long flags; >> > unsigned long tmp; > Likewise. > > There may be other places that need changes.
OK, I will check them.
Thanks. -- Chen Gang
Asianux Corporation
| |