lkml.org 
[lkml]   [2013]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/31] mips/kvm: Hook into TLB fault handlers.
    On 06/07/2013 04:34 PM, Sergei Shtylyov wrote:
    > Hello.
    >
    > On 06/08/2013 03:03 AM, David Daney wrote:
    >
    >> From: David Daney <david.daney@cavium.com>
    >>
    >> If the CPU is operating in guest mode when a TLB related excpetion
    >> occurs, give KVM a chance to do emulation.
    >>
    >> Signed-off-by: David Daney <david.daney@cavium.com>
    >> ---
    >> arch/mips/mm/fault.c | 8 ++++++++
    >> arch/mips/mm/tlbex-fault.S | 6 ++++++
    >> 2 files changed, 14 insertions(+)
    >>
    >> diff --git a/arch/mips/mm/fault.c b/arch/mips/mm/fault.c
    >> index 0fead53..9391da49 100644
    >> --- a/arch/mips/mm/fault.c
    >> +++ b/arch/mips/mm/fault.c
    > [...]
    >> @@ -50,6 +51,13 @@ asmlinkage void __kprobes do_page_fault(struct
    >> pt_regs *regs, unsigned long writ
    >> field, regs->cp0_epc);
    >> #endif
    >> +#ifdef CONFIG_KVM_MIPSVZ
    >> + if (test_tsk_thread_flag(current, TIF_GUESTMODE)) {
    >> + if (mipsvz_page_fault(regs, write, address))
    >
    > Any reason not to collapse these into single *if*?
    >

    It makes the conditional call to mipsvz_page_fault() less obvious.

    Certainly the same semantics can be achieved several different ways.

    David Daney


    >> + return;
    >> + }
    >> +#endif
    >> +
    >>
    >
    >




    \
     
     \ /
      Last update: 2013-06-08 02:21    [W:4.533 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site