Messages in this thread | | | From | Matthew Garrett <> | Subject | Re: [PATCH] Modify UEFI anti-bricking code | Date | Wed, 5 Jun 2013 16:08:39 +0000 |
| |
On Wed, 2013-06-05 at 16:59 +0100, Matt Fleming wrote:
> + /* clean DUMMY object */ > + efi.set_variable(efi_dummy_name, &EFI_DUMMY_GUID, 0, 0, NULL);
Hm. Actually, is that going to work? From the spec:
If a preexisting variable is rewritten with different attributes, SetVariable()shall not modify the variable and shall return EFI_INVALID_PARAMETER.
So I think we probably need to fix the attributes to NV|RT|BS for both this call and the one in query_variable_store. We should probably also only do the workaround if the NV bit is set in the original query.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |