lkml.org 
[lkml]   [2013]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:perf/urgent] perf: Fix perf mmap bugs
On Tue, Jun 04, 2013 at 10:44:21AM +0200, Peter Zijlstra wrote:
>
> Ingo asked for a delta against the patch already included in -tip.
>
> Vince; perf_fuzzer crashed after about 5670000 iterations -- not sure
> you're aware it will crash at times. Anyway at this time accounting was
> still good.
>
> ---
> Subject: perf: Fix mmap() accounting hole
>
> Vince's fuzzer once again found holes. This time it spotted a leak in
> the locked page accounting.
>
> When an event had redirected output and its close() was the last
> reference to the buffer we didn't have a vm context to undo accounting.
>
> Change the code to destroy the buffer on the last munmap() and detach
> all redirected events at that time. This provides us the right context
> to undo the vm accounting.
>
> Reported-by: Vince Weaver <vincent.weaver@maine.edu>
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>

Vince, can you confirm?


\
 
 \ /
  Last update: 2013-06-05 14:21    [W:0.070 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site