lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U'
On 06/03/2013 08:47 PM, David Laight wrote:
>>> +#define SKB_HEADER_UNSET_16 ((unsigned short) ~0U)
>>> > > +
>> >
>> > The _16 part isn't really correct, the type could be changed
>> > and then it would be wrong.
>> >
>> > I think I might have used SKB_HEADER_OFFSET.
> I meant SKB_HEADER_UNSET_OFFSET or SKB_HEADER_OFFSET_UNSET
>

It sound good, I choose the 2nd: 'SKB_HEADER_OFFSET_UNSET', for it may
be a 'noun', not a 'sentence'.

I will send patch v3 (also use '__u16' instead of 'unsigned short')


Thanks.
--
Chen Gang

Asianux Corporation


\
 
 \ /
  Last update: 2013-06-05 06:21    [W:0.271 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site