lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 084/184] xfrm_user: fix info leak in copy_to_user_state()
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit f778a636713a435d3a922c60b1622a91136560c1 ]

    The memory reserved to dump the xfrm state includes the padding bytes of
    struct xfrm_usersa_info added by the compiler for alignment (7 for
    amd64, 3 for i386). Add an explicit memset(0) before filling the buffer
    to avoid the info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    net/xfrm/xfrm_user.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
    index b95a2d6..4823a15 100644
    --- a/net/xfrm/xfrm_user.c
    +++ b/net/xfrm/xfrm_user.c
    @@ -506,6 +506,7 @@ out:

    static void copy_to_user_state(struct xfrm_state *x, struct xfrm_usersa_info *p)
    {
    + memset(p, 0, sizeof(*p));
    memcpy(&p->id, &x->id, sizeof(p->id));
    memcpy(&p->sel, &x->sel, sizeof(p->sel));
    memcpy(&p->lft, &x->lft, sizeof(p->lft));
    --
    1.7.12.2.21.g234cd45.dirty




    \
     
     \ /
      Last update: 2013-06-05 02:21    [W:2.359 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site