lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 137/184] isofs: avoid info leak on export
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathias Krause <minipli@googlemail.com>

    commit fe685aabf7c8c9f138e5ea900954d295bf229175 upstream.

    For type 1 the parent_offset member in struct isofs_fid gets copied
    uninitialized to userland. Fix this by initializing it to 0.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Cc: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    fs/isofs/export.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/isofs/export.c b/fs/isofs/export.c
    index e81a305..caec670 100644
    --- a/fs/isofs/export.c
    +++ b/fs/isofs/export.c
    @@ -131,6 +131,7 @@ isofs_export_encode_fh(struct dentry *dentry,
    len = 3;
    fh32[0] = ei->i_iget5_block;
    fh16[2] = (__u16)ei->i_iget5_offset; /* fh16 [sic] */
    + fh16[3] = 0; /* avoid leaking uninitialized data */
    fh32[2] = inode->i_generation;
    if (connectable && !S_ISDIR(inode->i_mode)) {
    struct inode *parent;
    --
    1.7.12.2.21.g234cd45.dirty




    \
     
     \ /
      Last update: 2013-06-05 01:41    [W:4.106 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site