lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 125/184] ext4: always set i_op in ext4_mknod()
    2.6.32-longterm review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>

    commit 6a08f447facb4f9e29fcc30fb68060bb5a0d21c2 upstream.

    ext4_special_inode_operations have their own ifdef CONFIG_EXT4_FS_XATTR
    to mask those methods. And ext4_iget also always sets it, so there is
    an inconsistency.

    Signed-off-by: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Willy Tarreau <w@1wt.eu>
    ---
    fs/ext4/namei.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
    index 902f69b..828c9c9 100644
    --- a/fs/ext4/namei.c
    +++ b/fs/ext4/namei.c
    @@ -1828,9 +1828,7 @@ retry:
    err = PTR_ERR(inode);
    if (!IS_ERR(inode)) {
    init_special_inode(inode, inode->i_mode, rdev);
    -#ifdef CONFIG_EXT4_FS_XATTR
    inode->i_op = &ext4_special_inode_operations;
    -#endif
    err = ext4_add_nondir(handle, dentry, inode);
    }
    ext4_journal_stop(handle);
    --
    1.7.12.2.21.g234cd45.dirty




    \
     
     \ /
      Last update: 2013-06-05 01:41    [W:4.041 / U:2.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site