Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv2 1/3] net: phy: prevent linking breakage | Date | Tue, 04 Jun 2013 18:01:07 +0200 |
| |
On Tuesday 04 June 2013 16:36:50 Florian Fainelli wrote: > It seems to me that what David proposes is to have say an > arch/arm/mach-foo/phy-fixups.c file which is only enabled when > CONFIG_PHYLIB is set (obj-$(CONFIG_PHYLIB) += phy-fixup.o), such that > it does not need to have any conditionnals when calling > phy_register_fixup. This sounds a little unusual, but why not.
I don't think it would actually help us, because then we still need to declare a local function that gets called from the board init code. Instead of doing
if (IS_ENABLED(CONFIG_PHYLIB)) phy_register_fixup_for_uid(phy_id, foo_phy_fixup);
we would then do
if (IS_ENABLED(CONFIG_PHYLIB)) foo_phy_fixup_register();
which is not much different at all.
Arnd
| |