Messages in this thread Patch in this message | | | Date | Tue, 4 Jun 2013 17:33:56 +0800 | From | Libo Chen <> | Subject | Re: [PATCH v2] scsi: megaraid: check kzalloc |
| |
we should check kzalloc, avoid to hit oops
Change from v1: - put kzalloc outside of mutex
Signed-off-by: Libo Chen <libo.chen@huawei.com> --- drivers/scsi/megaraid.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 846f475..cc599cc 100644 --- a/drivers/scsi/megaraid.c +++ b/drivers/scsi/megaraid.c @@ -4150,6 +4150,12 @@ mega_internal_command(adapter_t *adapter, megacmd_t *mc, mega_passthru *pthru) if (!scmd) return -ENOMEM;
+ sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL); + if (!sdev) { + scsi_free_command(GFP_KERNEL, scmd); + return -ENOMEM; + } + /* * The internal commands share one command id and hence are * serialized. This is so because we want to reserve maximum number of @@ -4160,7 +4166,6 @@ mega_internal_command(adapter_t *adapter, megacmd_t *mc, mega_passthru *pthru) scb = &adapter->int_scb; memset(scb, 0, sizeof(scb_t));
- sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL); scmd->device = sdev;
memset(adapter->int_cdb, 0, sizeof(adapter->int_cdb)); -- 1.7.1
| |