lkml.org 
[lkml]   [2013]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"
Date


> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@suse.cz]
> Sent: Monday, June 03, 2013 7:35 AM
> To: Thomas Meyer
> Cc: KY Srinivasan; Haiyang Zhang; devel@linuxdriverproject.org; linux-
> input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] HID: hyperv: Cocci spatch "memdup.spatch"
>
> On Sat, 1 Jun 2013, Thomas Meyer wrote:
>
> > Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> > ---
> >
> > diff -u -p a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> > --- a/drivers/hid/hid-hyperv.c
> > +++ b/drivers/hid/hid-hyperv.c
> > @@ -199,13 +199,11 @@ static void mousevsc_on_receive_device_i
> > if (desc->bLength == 0)
> > goto cleanup;
> >
> > - input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
> > + input_device->hid_desc = kmemdup(desc, desc->bLength,
> GFP_ATOMIC);
> >
> > if (!input_device->hid_desc)
> > goto cleanup;
> >
> > - memcpy(input_device->hid_desc, desc, desc->bLength);
> > -
> > input_device->report_desc_size = desc->desc[0].wDescriptorLength;
> > if (input_device->report_desc_size == 0) {
> > input_device->dev_info_status = -EINVAL;
> >
>
> I guess you are going to get some pushback from some maintainers due to
> non-descriptive subject and missing changelog :)
>
> I have fixed this for the hyperv patch and applied it, thanks.

Thanks Jiri!

K. Y
>
> --
> Jiri Kosina
> SUSE Labs
>




\
 
 \ /
  Last update: 2013-06-03 16:43    [W:0.057 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site