Messages in this thread | | | Date | Fri, 28 Jun 2013 10:51:07 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: Fix override new_cpu_data.x86 with 486 |
| |
On Fri, Jun 28, 2013 at 08:56:42AM +0800, Wang YanQing wrote: > > Right, so this patch is correct and it fixes the small window where we > > run with family == 4 before cpu_detect but the commit message needs a > > bit massaging before it gets applied. > > I think it fixes the window where we run with family > 4 before cpu_detect :)
Yes, before cpu_detect, the family is set to 4. And with "family" I mean
#define X86 new_cpu_data+CPUINFO_x86
and not the hardware family of the CPU and what you mean is that when we boot 32-bit on a hardware family != 4, we run with X86 == 4 until cpu_detect runs.
So basically we're saying the same thing. :)
> I can't catch the exactly meaning: > > We can drop the new_cpu_data or > I need to drop this part commit > message.
Yes, this part of the commit message.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |