Messages in this thread | | | Date | Sat, 29 Jun 2013 09:17:46 +1000 | From | Ryan Mallon <> | Subject | Re: [PATCH 3/8] spi: spi-ep93xx: always handle transfer specific settings |
| |
On 29/06/13 04:43, H Hartley Sweeten wrote:
> __spi_async(), which starts every SPI message transfer, initializes > the bits_per_word and max speed for every transfer in the message. > Since the conditional test in ep93xx_spi_process_transfer() will > always succeed just remove it and always call ep93xx_spi_chip_setup() > to configure the hardware for each transfer in the message. > > Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer() > which just initializes the hardware to the "default" based on the SPI > device. > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ryan Mallon <rmallon@gmail.com> > Cc: Mika Westerberg <mika.westerberg@iki.fi> > Cc: Mark Brown <broonie@kernel.org> > Cc: Grant Likely <grant.likely@linaro.org> > ---
> + err = ep93xx_spi_calc_divisors(espi, chip, t->speed_hz); > + if (err) { > + dev_err(&espi->pdev->dev, "failed to adjust speed\n");
Printing out the speed it was trying to set might be useful here?
~Ryan
| |