Messages in this thread | | | Date | Fri, 28 Jun 2013 13:44:51 -0700 | Subject | Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST | From | Tony Luck <> |
| |
On Fri, Jun 28, 2013 at 1:14 PM, Lenny Szubowicz <lszubowi@redhat.com> wrote:
> - if (pstore_register(&erst_info)) { > - pr_info(ERST_PFX "Could not register with persistent store\n"); > + rc = pstore_register(&erst_info); > + if (rc) { > + if (rc != -EPERM) > + pr_info(ERST_PFX > + "Could not register with persistent store\n"); > + erst_info.buf = NULL; > + erst_info.bufsize = 0;
Mismatch between part 1 and part 2 here ... we return -EINVAL if our name doesn't match the desired backend ... but you only suppress the "Could not register" message for -EPERM
Or am I confused while just looking at patch fragments?
-Tony
| |