Messages in this thread | | | Date | Fri, 28 Jun 2013 09:29:50 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/5] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id |
| |
On Fri, Jun 28, 2013 at 12:32:01AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > When building imx_v6_v7_defconfig with imx-drm drivers selected as modules, we > get the following build error: > > ERROR: "imx_drm_encoder_get_mux_id" [drivers/staging/imx-drm/imx-ldb.ko] undefined! So imx-ldb.c needs a symbol from imx-drm-core.c right? The alternative to exporting this symbol for a single user(?) is to link these two files into a single module. Does this make sense? If yes, that would IMHO be the better fix.
Best regards Uwe > > Export the required function to avoid this problem. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/staging/imx-drm/imx-drm-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c > index 9854a1d..6bc205b 100644 > --- a/drivers/staging/imx-drm/imx-drm-core.c > +++ b/drivers/staging/imx-drm/imx-drm-core.c > @@ -678,6 +678,7 @@ found: > > return i; > } > +EXPORT_SYMBOL_GPL(imx_drm_encoder_get_mux_id); > > /* > * imx_drm_remove_encoder - remove an encoder > -- > 1.8.1.2 > >
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |