lkml.org 
[lkml]   [2013]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 15/15] perf tools: fix ppid in thread__fork()
On 6/27/13 1:55 AM, Adrian Hunter wrote:
> ppid should be assigned to the parents pid. Note
> 'thread__fork()'s only caller 'machine__process_fork_event()'
> ensures that the parents pid is set.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/util/thread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> index e3d4a55..93f3eab 100644
> --- a/tools/perf/util/thread.c
> +++ b/tools/perf/util/thread.c
> @@ -85,7 +85,7 @@ int thread__fork(struct thread *self, struct thread *parent)
> if (map_groups__clone(&self->mg, &parent->mg, i) < 0)
> return -ENOMEM;
>
> - self->ppid = parent->tid;
> + self->ppid = parent->pid_;
>

knowledge of the specific thread within the parent that created the
process can be valuable -- that's what we get now. This change drops
that information. I'd prefer this stays at thread id -- or save the
parent thread id in addition to the pid.

David


\
 
 \ /
  Last update: 2013-06-27 19:41    [W:0.160 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site