Messages in this thread | | | Date | Wed, 26 Jun 2013 22:50:51 -0700 | Subject | Re: [PATCH] Optimize wait_sb_inodes() | From | Daniel Phillips <> |
| |
Hi Dave,
On Wed, Jun 26, 2013 at 9:47 PM, Dave Chinner <david@fromorbit.com> wrote: > You have your own wait code, that doesn't make what the VFS does > unnecesary. Quite frankly, I don't trust individual filesystems to > get it right - there's a long history of filesystem specific data > sync problems (including in XFS), and the best way to avoid that is > to ensure the VFS gets it right for you.
I agree that some of the methods Tux3 uses to implement data integrity, sync and friends may be worth lifting up to core, or better, to a library, but we will all be better served if such methods are given time to mature first. After all, that basically describes the entire evolution of the VFS: new concepts start in a filesystem, prove themselves useful, then may be lifted up to be shared.
It is important to get the order right: prove first, then lift.
Regards,
Daniel
| |