Messages in this thread | | | Subject | Re: [PATCH] ncpfs: fix rmdir returns Device or resource busy | From | Ben Hutchings <> | Date | Wed, 26 Jun 2013 02:05:42 +0100 |
| |
On Wed, 2013-06-19 at 10:30 +0100, Luis Henriques wrote: > Dave Chiluk <chiluk@canonical.com> writes: > > > 1d2ef5901483004d74947bbf78d5146c24038fe7 caused a regression in ncpfs such that > > directories could no longer be removed. This was because ncp_rmdir checked > > to see if a dentry could be unhashed before allowing it to be removed. Since > > 1d2ef5901483004d74947bbf78d5146c24038fe7 introduced a change that incremented > > dentry->d_count causing it to always be greater than 1 unhash would always > > fail. Thus causing the error path in ncp_rmdir to always be taken. Removing > > this error path is safe as unhashing is still accomplished by calls to dput > > from vfs_rmdir. > > Stable kernels starting with 3.0 also contain the offending commit, so > I believe this patch should be applied to stable kernels as well. > > Upstream commit is 698b8223631472bf982ed570b0812faa61955683.
Queued up for 3.2, thanks.
Ben.
-- Ben Hutchings Knowledge is power. France is bacon. [unhandled content-type:application/pgp-signature] | |