lkml.org 
[lkml]   [2013]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: DTS: OMAP4: Add OMAP4 Blaze Tablet support
On 06/25/2013 07:01 AM, Nishanth Menon wrote:
> On 06/25/2013 06:32 AM, Ruslan Bilovol wrote:
>> The OMAP4 Blaze Tablet is TI OMAP4 processor-based
>> development platform in a tablet formfactor.
>> The platform contains many of the features found in
>> present-day handsets (such as audio, video, wireless
>> functions and user interfaces) and in addition
>> contains features for software development and test.
>>
>> This patch adds initial support for the OMAP4 Blaze
>> Tablet development platform. Additional functionality
>> depends on different drivers and code modifications that
>> are not upstreamed yet or do not support DT yet, so will
>> be added later.
>
> http://svtronics.com/omap/sevm4460,blaze,omap might help too :)
> [...]
>> +
>> +#include "twl6030.dtsi"
>> +
> Might be good to see the TWL interrupt pin information made available as
> well?
Allow me to rephrase a comment a little bit more :)
Similar to twl4030_omap3.dtsi, we could introduce twl6030_omap4.dtsi.
this could contain the common pins used for 6030.
&omap4_pmx_wkup {
pinctrl-names = "default";
pinctrl-0 = <
&twl6030_wkup_pins
>;

twl6030_wkup_pins: pinmux_twl6030_wkup_pins {

pinctrl-single,pins = <
0x14 (PIN_OUTPUT | MUX_MODE2)
>;
};
};

twl6030_pins: pinmux_twl6030_pins {
pinctrl-single,pins = <
0x15e (WAKEUP_EN | PIN_INPUT_PULLUP | MUX_MODE0) /*
sys_nirq1.sys_nirq1 */
>;
};

which is now already duplicated in 2 places (SDP and Panda), and in this
patch duplicated again.

just my 2 cents :(
---
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2013-06-25 15:01    [W:0.144 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site