lkml.org 
[lkml]   [2013]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
Hello Thomas,

additionally to provide a proper log message it is a usual to provide the
coccinelle expression that found the source to be changed.

http://lwn.net/Articles/315686/


E.g. like these

http://marc.info/?l=linux-netdev&m=135081679626023&w=2
http://marc.info/?l=linux-netdev&m=135194048501621&w=2

http://marc.info/?l=linux-netdev&m=135306967411758&w=2
http://marc.info/?l=linux-netdev&m=135304902302198&w=2


Regards,
Oliver

On 02.06.2013 04:37, David Miller wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
> Date: Sat, 01 Jun 2013 11:59:11 +0200
>
>>
>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>
> This obscure reference to the cocci path you used to find/fix
> this problem is insufficient in detail for a commit log message.
>
> You must explain exactly what the problem is, and how you fixed
> it, in full sentences. You must make your commit header lin
> subject more appropriate as well.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>



\
 
 \ /
  Last update: 2013-06-02 11:41    [W:4.836 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site