Messages in this thread | | | Date | Sat, 1 Jun 2013 22:09:04 -0700 | Subject | Re: [PATCH v2] video: simplefb: add mode parsing function | From | Olof Johansson <> |
| |
On Sat, Jun 1, 2013 at 10:07 PM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 05/31/2013 11:12 PM, Olof Johansson wrote: >> On Mon, May 27, 2013 at 10:13:09PM -0600, Stephen Warren wrote: >>> On 05/26/2013 09:53 PM, Alexandre Courbot wrote: >>>> The naming scheme of simplefb's mode is precise enough to allow building >>>> the mode structure from it instead of using a static list of modes. This >>>> patch introduces a function that does this. In case exotic modes that >>>> cannot be represented from their name alone are needed, the static list >>>> of modes is still available as a backup. > ... >>> As such, we should either: >>> >>> a) Just add new entries into the format array that already exists in the >>> driver. Given David's response, this might be simplest. >> >> I think so too. Is this even needed? Do we have any users of the newer formats >> or is it just someone trying to feature-creep this driver to make the "simple" >> part of the name inaccurate? :) > > Alex is working on board support for a new NVIDIA board, where IIRC the > bootloader sets up some 32-bit ARGB format for the panel.
Ah, ok. Let's just implement that one format too then. :)
-Olof
| |