lkml.org 
[lkml]   [2013]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/16] perf, persistent: Kernel updates for perf tool integration
On Sat, Jun 01, 2013 at 06:15:55PM +0200, Robert Richter wrote:
> Instead I reviewed the code while developing it with certain goals in
> mind. Most changes I found necessary while building and running a
> modified version during development. That never could be found in a
> patch review. These changes are what we actually want to see in git
> history.

No, we don't. Not if my patches were never a baseline to begin with.

> And your argument that changes should be merged to reduce review
> effort would actually mean to drop all the code you introduce which is
> later removed in my patches (see below for the diff stats).

Yes, absolutely, if we have to. My version is an initial functionality
proposal and nothing more. It is Work-In-Progress, and, as such, is
very much a subject to change, or even a complete rewrite - whatever it
takes.

> I also don't think we need to re-review your patches. Most of it has
> been reviewed and should also not change much to avoid rebase

No, my patches haven't really been reviewed since they've been a moving
target from the very beginning. IOW, you simply stating that fixing
bugs against code which hasn't been the base line and agreed upon
functionality in the first place, is simply unnecessary churn.

If you want to document the goals you had in mind, just write that as
a comment in the code if it is very important or put it in a commit
message.

IOW, my patches were never ready but RFC. Nothing more.

> conflicts. In my point of view they are fine to be applied to a perf
> topic branch. Ingo, would this be ok? There is no messy history if we
> later just apply my patches on top. So no, I don't agree with you here
> to merge some of my patches.

Again, my patches are simply RFC and a moving target functionality-wise.
If you feel that something was done not in the way it should be done,
then pieces of maybe even them all should be thrown away and done right.
Simply redoing them or asking me to change them is all I'm saying.

Thanks.


\
 
 \ /
  Last update: 2013-06-02 10:21    [W:0.055 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site