Messages in this thread |  | | Date | Wed, 19 Jun 2013 10:48:53 -0700 | From | Dirk Brandewie <> | Subject | Re: [PATCH v4 2/7] cpufreq: Add boost frequency support in core |
| |
On 06/19/2013 10:12 AM, Lukasz Majewski wrote: > This commit adds boost frequency support in cpufreq core (Hardware &
> +/********************************************************************* > * REGISTER / UNREGISTER CPUFREQ DRIVER * > *********************************************************************/ > > @@ -1936,6 +2019,16 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data) > cpufreq_driver = driver_data; > write_unlock_irqrestore(&cpufreq_driver_lock, flags); > > + if (!cpufreq_driver->boost_supported) > + boost.attr.mode = 0444; > + > + ret = cpufreq_sysfs_create_file(&(boost.attr)); > + if (ret) { > + pr_err("%s: cannot register global boost sysfs file\n", > + __func__); > + goto err_null_driver; > + } > +
I do not think the boost sysfs should be created at all if boost is not supported.
For intel_pstate the read-only boost would be there for no reason and would cause confusion on the part of the user IMHO
> ret = subsys_interface_register(&cpufreq_interface); > if (ret) > goto err_null_driver; > @@ -1992,6 +2085,8 @@ int cpufreq_unregister_driver(struct cpufreq_driver *driver) > pr_debug("unregistering driver %s\n", driver->name); > > subsys_interface_unregister(&cpufreq_interface); > + > + cpufreq_sysfs_remove_file(&(boost.attr)); > unregister_hotcpu_notifier(&cpufreq_cpu_notifier); >
|  |