lkml.org 
[lkml]   [2013]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/4] mfd: Kontron PLD mfd driver
    On Tue, 18 Jun 2013, Kevin Strasser wrote:

    This patch set looks reasonable now, except a formal issue.

    > Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
    > Signed-off-by: Michael Brunner <michael.brunner@kontron.com>

    This is wrong, as it says:

    Kevin authored the code, sent it to Michael and Michael sent it to
    LKML.


    The original code was authored by Michael. This version was authored
    by Kevin based on Michaels code.

    So either you keep Michael as the author, then you want

    From: Michael Brunner <michael.brunner@kontron.com>

    <patch description/>

    Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
    Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>

    or you decide that it's a major rewrite by you, then you want:

    This patch is based on the original version authored by
    Michael Brunner <michael.brunner@kontron.com>.

    Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>

    Or

    Originally-From: Michael Brunner <michael.brunner@kontron.com>.
    Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>

    Other than that.

    Acked-by: Thomas Gleixner <tglx@linutronix.de>


    \
     
     \ /
      Last update: 2013-06-19 13:21    [W:4.174 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site