Messages in this thread | | | Date | Mon, 17 Jun 2013 23:26:59 +0800 | From | Alex Shi <> | Subject | Re: [RFC patch 2/4] sched/tg: use 'unsigned long' for load variable in task group |
| |
On 06/17/2013 08:25 PM, Paul Turner wrote: > On Fri, Jun 7, 2013 at 12:29 AM, Alex Shi <alex.shi@intel.com> wrote: >> > Since tg->load_avg is smaller than tg->load_weight, we don't need a >> > atomic64_t variable for load_avg in 32 bit machine. >> > The same reason for cfs_rq->tg_load_contrib. > This description is incorrect, another patch removes tg->load_weight > for being unused.
You can say this, but tg->load_weight was designed for the same meaning as load_avg before. :) > > Rest seems fine.
thanks for review.
-- Thanks Alex
| |