Messages in this thread | | | Date | Mon, 17 Jun 2013 22:15:26 +0800 | From | Alex Shi <> | Subject | Re: [patch v8 8/9] sched: consider runnable load average in move_tasks |
| |
On 06/17/2013 10:01 PM, Alex Shi wrote: > On 06/17/2013 06:58 PM, Paul Turner wrote: >>>> + unsigned long tmp_rla; >>>> + tmp_rla = tg->parent->cfs_rq[cpu]->runnable_load_avg + 1; >>>> + >>>> load = tg->parent->cfs_rq[cpu]->h_load; >>>> - load *= tg->se[cpu]->load.weight; >>>> - load /= tg->parent->cfs_rq[cpu]->load.weight + 1; >>>> + load *= tg->se[cpu]->avg.load_avg_contrib; >>>> + load /= tmp_rla; >> Why do we need the temporary here? >> > > you'r right. tmp_rla is not necessary here. >
Sorry, not, tmp_rla is a imply type casting. otherwise long /= u64; has building issue on 32 bit according to Morten. and a clear type casting cross 2 lines.
-- Thanks Alex
| |