Messages in this thread | | | Date | Mon, 17 Jun 2013 15:39:34 +0200 | From | Peter Zijlstra <> | Subject | Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task |
| |
On Mon, Jun 17, 2013 at 05:17:17AM -0700, Paul Turner wrote: > On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner <pjt@google.com> wrote: > > On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi <alex.shi@intel.com> wrote: > >> They are the base values in load balance, update them with rq runnable > >> load average, then the load balance will consider runnable load avg > >> naturally. > >> > >> We also try to include the blocked_load_avg as cpu load in balancing, > >> but that cause kbuild performance drop 6% on every Intel machine, and > >> aim7/oltp drop on some of 4 CPU sockets machines. > >> > > > > This looks fine. > > > > Did you try including blocked_load_avg in only get_rq_runnable_load() > > [ and not weighted_cpuload() which is called by new-idle ]? > > Looking at this more this feels less correct since you're taking > averages of averages. > > This was previously discussed at: > https://lkml.org/lkml/2013/5/6/109 > > And you later replied suggesting this didn't seem to hurt; what's the > current status there?
Wasn't there a follow up series (currently as RFC or so) that proposes to removes the entire *_idx stuff?
| |