lkml.org 
[lkml]   [2013]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 2/6] GPIO: xilinx: Add support for dual channel
    From
    On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek <michal.simek@xilinx.com> wrote:

    > Supporting the second channel in the driver.
    > Offset is 0x8 and both channnels share the same
    > IRQ.
    >
    > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
    >
    > ---
    > Changes in v2:
    > - Use kernel doc format - suggested by Linus Walleij
    > - Do not use __raw_readl/__raw_writel IO in this patch
    > - Use of_property_read_u32 helper function
    > - Use BIT()
    > - Change patch subject

    Patch is looking overall nice and improves the kernel so
    applied.

    But check this:

    > @@ -202,6 +230,57 @@ static int xgpio_of_probe(struct device_node *np)
    > np->full_name, status);
    > return status;
    > }
    > +
    > + pr_info("XGpio: %s: registered, base is %d\n", np->full_name,
    > + chip->mmchip.gc.base);
    > +
    > + tree_info = of_get_property(np, "xlnx,is-dual", NULL);
    > + if (tree_info && be32_to_cpup(tree_info)) {

    Doesn't this work:

    if (of_property_read_bool(np, "xlnx,is-dual")) {
    (...)

    ?

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2013-06-17 08:21    [W:4.384 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site