Messages in this thread | | | Date | Mon, 17 Jun 2013 07:44:37 +0200 | Subject | Re: [PATCH v2 2/6] GPIO: xilinx: Add support for dual channel | From | Linus Walleij <> |
| |
On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> Supporting the second channel in the driver. > Offset is 0x8 and both channnels share the same > IRQ. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > --- > Changes in v2: > - Use kernel doc format - suggested by Linus Walleij > - Do not use __raw_readl/__raw_writel IO in this patch > - Use of_property_read_u32 helper function > - Use BIT() > - Change patch subject
Patch is looking overall nice and improves the kernel so applied.
But check this:
> @@ -202,6 +230,57 @@ static int xgpio_of_probe(struct device_node *np) > np->full_name, status); > return status; > } > + > + pr_info("XGpio: %s: registered, base is %d\n", np->full_name, > + chip->mmchip.gc.base); > + > + tree_info = of_get_property(np, "xlnx,is-dual", NULL); > + if (tree_info && be32_to_cpup(tree_info)) {
Doesn't this work:
if (of_property_read_bool(np, "xlnx,is-dual")) { (...)
?
Yours, Linus Walleij
| |