Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | [PATCH 8/9] x86: remove weird PTR_ERR() in do_debug | Date | Sun, 16 Jun 2013 14:12:47 +0930 |
| |
62edab905 changed the argument to notify_die() from dr6 to &dr6, but weirdly, used PTR_ERR() to cast it to a long. Since dr6 is on the stack, this is an abuse of PTR_ERR(). Cast to long, as per kernel standard.
Cc: x86@kernel.org Cc: K.Prasad <prasad@linux.vnet.ibm.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- arch/x86/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index 772e2a8..9340dfb 100644 --- a/arch/x86/kernel/traps.c +++ b/arch/x86/kernel/traps.c @@ -437,7 +437,7 @@ dotraplinkage void __kprobes do_debug(struct pt_regs *regs, long error_code) /* Store the virtualized DR6 value */ tsk->thread.debugreg6 = dr6; - if (notify_die(DIE_DEBUG, "debug", regs, PTR_ERR(&dr6), error_code, + if (notify_die(DIE_DEBUG, "debug", regs, (long)&dr6, error_code, SIGTRAP) == NOTIFY_STOP) goto exit; -- 1.8.1.2
| |