lkml.org 
[lkml]   [2013]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] etzkx accelerometer support
On Mon, Jun 17, 2013 at 12:26:48AM +0200, Andi Shyti wrote:
> > > these two patches provide the etzkx device driver which supports
> > > the following accelerometers:
> > >
> > > - Kionix kxcnl
> > > - Kionix kxtnk
> > > - ST lisn3dsh
> > >
> > > Support for ST lis3dsh accelerometer is still in progress.
> > >
> > > The etzkx accelerometers are a kind of devices that are able to
> > > do gesture recognition directly on the device. It uses two slots
> > > of 16 steps (bytes) each for loading algorithms which perform
> > > gesture recognition.
> > >
> > > The second patch contains the documentation of the device driver.
> > >
> > > On http://www.etezian.org/etzkx/etzkx/ is possible to find more
> > > informations about the accelerometer.
> >
> > Why isn't this a drivers/iio/accel/ driver instead of a misc driver?
> > Please make this an iio driver, then you will be using the correct
> > user/kernel api to talk to your device.
>
> I was thinking it may be an issue, but it's not iio because the
> time I developed the driver, iio was in the first staging period
> and mainly because the on the board I'm using I cannot update the
> Kernel to use the latest iio.
>
> I guess you don't like the promise "I can do it later" once the
> supplier sends me a development board (which is planned) :)

Sure, I'll gladly accept "I can do it later" from anyone, as long as you
don't mind my, "I will merge it later" as well :)

Sorry, I can't accept a driver now, that is known to going to be
changing the kernel/user api in the future. So please, rewrite it to
use IIO, that's what that interface / subsystem is there for.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-06-17 06:01    [W:0.048 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site