Messages in this thread | | | Date | Fri, 14 Jun 2013 10:57:12 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v2 13/14] perf, persistent: Exposing persistent events using sysfs |
| |
On 14.06.13 11:36:00, Namhyung Kim wrote: > > +static int pers_event_sysfs_register(struct pers_event *event) > > +{ > > + struct device_attribute *attr = &event->sysfs.attr; > > + int idx; > > + > > + *attr = (struct device_attribute)__ATTR(, 0444, pers_event_sysfs_show, > > + NULL); > > + attr->attr.name = event->name; > > When I added another persistent event with this API, I got an WARNING > from lockdep like this: > > [ 0.432506] BUG: key ffff88040946f140 not in .data! > [ 0.432581] ------------[ cut here ]------------ > [ 0.432656] WARNING: at /home/namhyung/project/linux/kernel/lockdep.c:2987 lockdep_init_map+0x53d/0x570() > [ 0.432763] DEBUG_LOCKS_WARN_ON(1) > > > I guess we need the following line here: > > sysfs_attr_init(&attr->attr);
Yes, added your change. Thanks Namhyung for reviewing and testing.
-Robert
| |