Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port | Date | Fri, 14 Jun 2013 00:06:51 +0200 |
| |
On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote: > + > + ahb@80080000 { > + usb0: usb@80080000 { > + pinctrl-names = "default"; > + pinctrl-0 = <&usb0_otg_cfa10036>; > + status = "okay"; > }; > }; >
The patches all look good, just one trivial comment about the fragment above:
There is already a "usb0" label in the imx28.dtsi file for the same node. When you refer to the node from a board.dts file, either leave out the redundant label, or use it to simplify the statements above to the brief version:
&usb0 { pinctrl-names = "default"; pinctrl-0 = <&usb0_otg_cfa10036>; status = "okay"; };
Arnd
| |