lkml.org 
[lkml]   [2013]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC: PATCH] err.h: silence warning when using IS_ERR on void __iomem *
On Thu, 13 Jun 2013 20:24:48 +0200 Thierry Reding <thierry.reding@gmail.com> wrote:

> On Thu, Jun 13, 2013 at 10:55:17AM +0530, Sachin Kamat wrote:
> > On 13 June 2013 03:01, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > > Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()")
> > > introduced devm_ioremap_resource() and encourage to check its return value with
> > > IS_ERR(). This however leads to the following sparse warnings, as
> > > devm_ioremap_resource() returns a void __iomem pointer:
> > >
> > > drivers/net/can/c_can/c_can_platform.c:205:32: warning: incorrect type in argument 1 (different address spaces)
> > > drivers/net/can/c_can/c_can_platform.c:205:32: expected void const *ptr
> > > drivers/net/can/c_can/c_can_platform.c:205:32: got unsigned int [noderef] [usertype] <asn:2>*raminit_ctrlreg
> >
> > CC ing Thierry who has solved this issue some time back.
>
> I had sent two patches, one against sparse, the other against the
> kernel, but none were picked up yet.

I didn't know that.

On May 8 I queued
http://ozlabs.org/~akpm/mmots/broken-out/errh-is_err-can-accept-__user-pointers.patch.
Dan says that sparse v0.4.5-rc1 or later is also required.


\
 
 \ /
  Last update: 2013-06-13 23:01    [W:0.074 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site