Messages in this thread Patch in this message | | | From | Jason Wang <> | Subject | [net-next PATCH V2 2/2] macvtap: fix uninitialized return value macvtap_ioctl_set_queue() | Date | Thu, 13 Jun 2013 14:23:36 +0800 |
| |
Return -EINVAL on illegal flag instead of uninitialized value. This fixes the kbuild test warning.
Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/macvtap.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index edcbf1c..5a76f20 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -969,6 +969,8 @@ static int macvtap_ioctl_set_queue(struct file *file, unsigned int flags) ret = macvtap_enable_queue(vlan->dev, file, q); else if (flags & IFF_DETACH_QUEUE) ret = macvtap_disable_queue(q); + else + ret = -EINVAL; macvtap_put_vlan(vlan); return ret; -- 1.7.1
| |