Messages in this thread | | | Date | Thu, 13 Jun 2013 20:20:06 +0200 | Subject | Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking | From | Linus Walleij <> |
| |
On Thu, Jun 13, 2013 at 6:38 PM, Doug Anderson <dianders@chromium.org> wrote:
> A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Signed-off-by: Luigi Semenzato <semenzato@chromium.org> > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > Changes in v2: > - Greatly simplified using Tomasz's suggestion of irqd_get_trigger_type > - Moved acking out of the bank spinlock since since it's not needed. > - Linus W. has already applied parts 1 and 2, so not resending.
Thanks, this v2 version applied with Tomasz ACK.
Yours, Linus Walleij
| |