Messages in this thread | | | Date | Thu, 13 Jun 2013 07:02:51 +0200 | From | Michal Simek <> | Subject | Re: [PATCH v2 3/3] arm: dt: zynq: Add support for the zed platform |
| |
On 06/12/2013 10:16 PM, Sören Brinkmann wrote: > On Wed, Jun 12, 2013 at 09:33:58PM +0200, Steffen Trumtrar wrote: >> On Wed, Jun 12, 2013 at 11:26:34AM -0700, Sören Brinkmann wrote: >>> On Wed, Jun 12, 2013 at 08:23:45PM +0200, Steffen Trumtrar wrote: >>>> On Wed, Jun 12, 2013 at 09:41:08AM -0700, Soren Brinkmann wrote: >>>>> Add a DT fragment for the Zed Zynq platform and a corresponding >>>>> target to the Makefile >>>>> >>>>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> >>>>> --- >>>>> I used the 'xlnx,...' compat strings since it seems this is what is >>>>> used in the Xilinx and Digilent vendor trees. >>>>> >>>>> +/include/ "zynq-7000.dtsi" >>>>> + >>>>> +/ { >>>>> + model = "Zynq Zed Development Board"; >>>>> + compatible = "xlnx,zynq-zed", "xlnx,zynq-7000"; >>>>> + >>>>> + memory { >>>>> + device_type = "memory"; >>>>> + reg = <0 0x20000000>; >>>>> + }; >>>>> + >>>>> + chosen { >>>>> + bootargs = "console=ttyPS1,115200 earlyprintk"; >>>>> + }; >>>>> + >>>>> +}; >>>> >>>> Hi! >>>> >>>> This looks a little bit to basic. No?! Not even an UART? >>> The UART is imported from the common zynq-7000.dtsi. >> >> Hm, you are actually right, although I think that you shouldn't be. >> It is possible to NOT use the UARTs, isn't it? So, default on for both UARTs is wrong. > Well, in that case the dtsi has to be fixed to add the 'status = "disabled" > property to the UARTs which then can be overridden in the board dts files > as needed. I guess I'll prepare another patch for a v3 for adding status > properties to the UART nodes.
I am ok with this. Just to be sure that we will probably need to start to use port-number to reflect which port is first, second.
>>>> The compatible should include digilent or avnet. Digilent only sells to academic >>>> customers, Avnet doesn't. >>> I don't care at all. So, who makes the decision which one is the correct >>> one? Actually we could even drop the zed specific one completely and go >>> with 'xlnx,zynq-7000' only. >> >> I'm okay with that. > Okay, let's wait a little and see if there are other opinions and then I > can prepare a v3.
AFAIK Digilent is producer, Avnet is reseller. I think it is enough to write in description ZedBoard and don't mentioned manufacturer.
By my previous comment I thought to have there just zynq-7000 compatible string without any additional zc702/zc706 or zed board properties.
Thanks, Michal
-- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[unhandled content-type:application/pgp-signature] | |