lkml.org 
[lkml]   [2013]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] sound/sgtl5000: fix codec register initial values and mask
On 06/11/2013 12:22 PM, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so initially setting the register to 0x0008
> does not make much sense. Instead, bit 4 should be marked set,
> as this is the power up default.
>
> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.
>
> Signed-off-by: Oskar Schirmer <oskar@scara.com>
> Tested-by: Fabio Estevam <fabio.estevam@freescale.com>

Looks good, but please copy Mark Brown. Just added him in Cc now.


> ---
> sound/soc/codecs/sgtl5000.c | 2 +-
> sound/soc/codecs/sgtl5000.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index d441559..10092ba 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -38,7 +38,7 @@
> static const struct reg_default sgtl5000_reg_defaults[] = {
> { SGTL5000_CHIP_CLK_CTRL, 0x0008 },
> { SGTL5000_CHIP_I2S_CTRL, 0x0010 },
> - { SGTL5000_CHIP_SSS_CTRL, 0x0008 },
> + { SGTL5000_CHIP_SSS_CTRL, 0x0010 },
> { SGTL5000_CHIP_DAC_VOL, 0x3c3c },
> { SGTL5000_CHIP_PAD_STRENGTH, 0x015f },
> { SGTL5000_CHIP_ANA_HP_CTRL, 0x1818 },
> diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
> index 4b69229..52bd843 100644
> --- a/sound/soc/codecs/sgtl5000.h
> +++ b/sound/soc/codecs/sgtl5000.h
> @@ -347,7 +347,7 @@
> #define SGTL5000_PLL_INT_DIV_MASK 0xf800
> #define SGTL5000_PLL_INT_DIV_SHIFT 11
> #define SGTL5000_PLL_INT_DIV_WIDTH 5
> -#define SGTL5000_PLL_FRAC_DIV_MASK 0x0700
> +#define SGTL5000_PLL_FRAC_DIV_MASK 0x07ff
> #define SGTL5000_PLL_FRAC_DIV_SHIFT 0
> #define SGTL5000_PLL_FRAC_DIV_WIDTH 11
>
>




\
 
 \ /
  Last update: 2013-06-11 18:21    [W:0.065 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site