lkml.org 
[lkml]   [2013]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: vexpress: Make the driver optional for arm and arm64
On Mon, Jun 10, 2013 at 04:09:15PM +0100, Pawel Moll wrote:
> The driver can be used on either arm or arm64 platforms, but
> the latter doesn't have any platform-specific configuration
> options, so it must be possible to manually enable the driver.
>
> As the gpiolib is optional for arm64 arch, the gpio/led code
> must be compiled conditionally.
>
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> ---
> drivers/mfd/Kconfig | 3 ++-
> drivers/mfd/vexpress-sysreg.c | 10 ++++++++--
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
> Hi Samuel,
>
> Could you please queue this small change for 3.11?

Please use #ifdef rather than a single #if defined(). #if defined()
on its own is unnecessarily ugly.



\
 
 \ /
  Last update: 2013-06-11 01:41    [W:0.053 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site