Messages in this thread | | | Date | Mon, 10 Jun 2013 15:26:26 -0700 | Subject | Re: [Suggestion] arch/*/include/asm/bitops.h: about __set_bit() API. | From | Tony Luck <> |
| |
On Sat, Jun 8, 2013 at 3:08 AM, Chen Gang <gang.chen@asianux.com> wrote: > using 'unsigned int *', implicitly: > ./ia64/include/asm/bitops.h:63:__set_bit (int nr, volatile void *addr)
There is some downside on ia64 to your suggestion. If "addr" is properly aligned for an "int", but misaligned for a long ... i.e. addr%8 == 4, then I'll take an unaligned reference trap if I work with long* where the current code working with int* does not.
Now perhaps all the callers do guarantee long* alignment? But I don't know.
Apart from uniformity, there doesn't see to be any upside to changing this.
-Tony Luck
| |