Messages in this thread | | | Date | Mon, 10 Jun 2013 21:39:58 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v3 10/27] genirq: Split __irq_reserve_irqs from irq_alloc_descs |
| |
On Fri, 7 Jun 2013, Yinghai Lu wrote: > /** > - * irq_alloc_descs - allocate and initialize a range of irq descriptors > - * @irq: Allocate for specific irq number if irq >= 0 > + * __irq_reserve_descs - reserve and initialize a range of irq descriptors
Did you even bother to run docbook ?
No you didn't. Otherwise you'd have noticed that documentation for __irq_reserve_descs is not the right thing for a function named __irq_reserve_irqs.
> + * __irq_reserve_descs - reserve and initialize a range of irq descriptors
The function only reserves a range of irq descriptors and does not initialize them.
> + > +/** > + * irq_alloc_descs - allocate and initialize a range of irq descriptors
Again you document non matching function names.
> +int __ref > +__irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node, > + struct module *owner)
Sloppy as usual along with a sucky changelog as usual.....
Thanks,
tglx
| |