lkml.org 
[lkml]   [2013]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv4 14/39] thp, mm: rewrite delete_from_page_cache() to support huge pages
Date
Dave Hansen wrote:
> On 06/07/2013 08:10 AM, Kirill A. Shutemov wrote:
> > + /*
> > + * When we add a huge page to page cache we take only reference to head
> > + * page, but on split we need to take addition reference to all tail
> > + * pages since they are still in page cache after splitting.
> > + */
> > + init_tail_refcount = PageAnon(page) ? 0 : 1;
>
> What's the "init" for in the name?

initial_tail_refcount?

> In add_to_page_cache_locked() in patch 12/39, you do
> > + spin_lock_irq(&mapping->tree_lock);
> > + for (i = 0; i < nr; i++) {
> > + page_cache_get(page + i);
>
> That looks to me to be taking references to the tail pages. What gives? :)

The point is to drop this from add_to_page_cache_locked() and make distribution
on split.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-06-10 20:01    [W:0.095 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site