Messages in this thread | | | Subject | Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber | From | Lubomir Rintel <> | Date | Mon, 10 Jun 2013 19:38:54 +0200 |
| |
On Mon, 2013-06-10 at 13:05 +0200, Hans Verkuil wrote: > > Also, I the hardware uses V4L2_FIELD_ALTERNATE interlacing, but I couldn't make > > it work, > > What didn't work exactly?
Both mplayer and gstream v4l2src displayed only half of an image. Not sure which combinations of flags did I use anymore.
> > +static int usbtv_queryctrl(struct file *file, void *priv, > > + struct v4l2_queryctrl *ctrl) > > +{ > > + return -EINVAL; > > +} > > Drop this ioctl. If it doesn't do anything, then don't specify it.
It actually does something; EINVAL here for any ctrl signals there's zero controls.
When undefined, ENOTTY that is returned is considered invalid by gstreamer source.
> It doesn't look too bad :-) You're using all the latest frameworks which is > excellent.
Thanks for your time. I'll follow up with a new version that aims to address all the concerns above (apart for the queryctl change, which would break with gstreamer).
> Can you run the v4l2-compliance tool and post the output of that tool?
Driver Info: Driver name : usbtv Card type : usbtv Bus info : usb-0000:00:1d.7-5 Driver version: 3.10.0 Capabilities : 0x85000001 Video Capture Read/Write Streaming Device Capabilities Device Caps : 0x05000001 Video Capture Read/Write Streaming
Compliance test for device /dev/video1 (not using libv4l2):
Required ioctls: test VIDIOC_QUERYCAP: OK
Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK
Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)
Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0
Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0
Control ioctls: test VIDIOC_QUERYCTRL/MENU: OK test VIDIOC_G/S_CTRL: OK (Not Supported) test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0
Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
Total: 36, Succeeded: 36, Failed: 0, Warnings: 0
-- Lubomir Rintel <lkundrak@v3.sk>
| |