Messages in this thread | | | Date | Mon, 10 Jun 2013 10:29:18 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v2 1/2] ARM: dts: add dtsi for palmas |
| |
On 06/10/2013 03:04 AM, J Keerthy wrote: > Adds palmas mfd and palmas regulator nodes.
Nits:
Well, you're really adding files that provide the nodes, not the nodes themselves.
Palmas and MFD should be correctly capitalized.
> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
> +&palmas { ... > + palmas_pmic { ... > + ti,ldo6-vibrator;
Isn't that board-specific? I don't know the HW well enough to say, but I assume that since there's a property, the whole point must be that some boards want it set and some don't.
> + regulators { > + smps123_reg: smps123 { > + regulator-name = "smps123"; > + };
So the node labels here duplicate those in omap5-uevm.dts in patch 2/2. While dtc allows this, I don't think there's much point duplicating the labels. I'd tend to only put the labels in omap5-uevm.dts and not put them here. That will completely avoid the possibility of the labels in this file from conflicting with any other labels in any top-level board.dts file.
I also wonder if this file is actually terribly useful. The only thing that this file provides is the regulator-name property. It seems simpler just to put that into each board.dts file. The added advantage of doing that, is that if a board doesn't use a particular regulator, the node won't appear, and the regulator won't get registered.
| |