Messages in this thread | | | Date | Mon, 10 Jun 2013 08:09:20 +0100 | From | Srinivas KANDAGATLA <> | Subject | Re: [RFC] regmap: Add regmap_field APIs |
| |
On 09/06/13 17:00, Lars-Peter Clausen wrote: > [...] >> +int regmap_field_write(struct regmap_field *field, unsigned int val) >> +{ >> + int field_bits; >> + unsigned int reg_mask; >> + field_bits = field->msb - field->lsb + 1; >> + reg_mask = ((BIT(field_bits) - 1) << field->lsb); >> + return regmap_update_bits(field->regmap, field->reg, >> + reg_mask, val << field->lsb); > > Considering that you'd do the same calculations over and over again it would > probably make more sense store the mask rather than the msb in the struct It makes sense, I will do that change.
Thanks, srini > >> +} >> +EXPORT_SYMBOL_GPL(regmap_field_write);
| |