Messages in this thread | | | Date | Mon, 10 Jun 2013 15:48:17 +0200 | From | Michael Holzheu <> | Subject | Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature |
| |
On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke <d.hatayama@gmail.com> wrote:
> > -static int setup_kdump_elfcorehdr(void) > > +void elfcorehdr_free(void) > > { > > - size_t elfcorebuf_sz; > > - char *elfcorebuf; > > - > > - if (!OLDMEM_BASE || is_kdump_kernel()) > > - return -EINVAL; > > - s390_elf_corehdr_create(&elfcorebuf, &elfcorebuf_sz); > > - elfcorehdr_addr = (unsigned long long) elfcorebuf; > > - elfcorehdr_size = elfcorebuf_sz; > > - return 0; > > + if (!elfcorehdr_newmem) > > + return; > > + vfree(elfcorehdr_newmem); > > kfree is correct here?
You are right, I fixed that!
Thanks! Michael
| |