Messages in this thread | | | Date | Mon, 10 Jun 2013 22:16:04 +0900 | From | Takuya Yoshikawa <> | Subject | Re: [PATCH v3 3/6] KVM: MMU: make return value of mmio page fault handler more readable |
| |
On Mon, 10 Jun 2013 10:57:50 +0300 Gleb Natapov <gleb@redhat.com> wrote:
> On Fri, Jun 07, 2013 at 04:51:25PM +0800, Xiao Guangrong wrote:
> > + > > +/* > > + * Return values of handle_mmio_page_fault_common: > > + * RET_MMIO_PF_EMULATE: it is a real mmio page fault, emulate the instruction > > + * directly. > > + * RET_MMIO_PF_RETRY: let CPU fault again on the address. > > + * RET_MMIO_PF_BUG: bug is detected. > > + */ > > +enum { > > + RET_MMIO_PF_EMULATE = 1, > > + RET_MMIO_PF_RETRY = 0, > > + RET_MMIO_PF_BUG = -1 > > +}; > I would order them from -1 to 1 and rename RET_MMIO_PF_BUG to > RET_MMIO_PF_ERROR, but no need to resend just for that.
Why not just let compilers select the values? -- It's an enum. Any reason to make it start from -1?
Takuya
| |