| Date | Mon, 10 Jun 2013 10:35:31 +0100 | From | Nick Dyer <> | Subject | Re: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe |
| |
Yufeng Shen wrote: >> + dev_info(&client->dev, >> + "Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n", >> + info->family_id, info->variant_id, info->version >> 4, >> + info->version & 0xf, info->build, info->object_num); >> + > > Use data->info->XXX here, info was pointing to buf which could have > changed after krealloc.
Thank you, that's a really good spot. Caused when I merged the dev_info line into that function. It actually explains a report I had about getting junk in this output but the info_crc check succeeding, hadn't had time to investigate yet.
I will fix.
|