lkml.org 
[lkml]   [2013]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 44/53] Input: atmel_mxt_ts - Verify Information Block checksum on probe
Yufeng Shen wrote:
>> + dev_info(&client->dev,
>> + "Family: %u Variant: %u Firmware V%u.%u.%02X Objects: %u\n",
>> + info->family_id, info->variant_id, info->version >> 4,
>> + info->version & 0xf, info->build, info->object_num);
>> +
>
> Use data->info->XXX here, info was pointing to buf which could have
> changed after krealloc.

Thank you, that's a really good spot. Caused when I merged the dev_info
line into that function. It actually explains a report I had about getting
junk in this output but the info_crc check succeeding, hadn't had time to
investigate yet.

I will fix.


\
 
 \ /
  Last update: 2013-06-10 12:21    [W:0.428 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site