Messages in this thread | | | From | Namhyung Kim <> | Date | Sun, 2 Jun 2013 11:50:55 +0900 | Subject | Re: [PATCH 3/5] perf gtk/hists: Display callchain overhead also |
| |
Hi Ingo,
On Tue, May 28, 2013 at 5:48 PM, Ingo Molnar <mingo@kernel.org> wrote: > > * Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote: > >> Em Wed, May 22, 2013 at 05:27:36PM +0900, Namhyung Kim escreveu: >> > From: Namhyung Kim <namhyung.kim@lge.com> >> > >> > Add a new column for showing callchain overhead. I feel like it's >> > more natural than having those overhead next to a first child in a >> > same column. >> >> Callchains in GTK, great! Some observations tho: >> >> All those leaves with 0.00% looks ugly/not needed, right? >> >> I took a screenshot and put at: >> >> http://vger.kernel.org/~acme/perf-gtk-callchains.png > > Looks really nice!
Thanks! :)
> > I'm wondering, would it be hard to add alternating lightgrey+white > background colors to make the entries striped and for the horizontal > structure to thus stand out better? > > The 'qgit' tool does that for example, to alternate git commit log > entries. > > (Extra points for striping only where the line actually begins.)
It should be easy, I'll add it in the next spin.
-- Thanks, Namhyung
| |